RFR: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails [v2]
Jayathirth D V
jdv at openjdk.org
Wed Nov 16 03:44:16 UTC 2022
On Tue, 15 Nov 2022 18:00:26 GMT, Phil Race <prr at openjdk.org> wrote:
>> test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java line 31:
>>
>>> 29: * @author Dmitri.Trembovetski at sun.com: area=Graphics
>>> 30: * @run main/othervm OnScreenRenderingResizeTest
>>> 31: * @run main/othervm -Dsun.java2d.d3d=false OnScreenRenderingResizeTest
>>
>> DirectDraw/GDI is default pipeline in Windows(https://docs.oracle.com/javase/10/troubleshoot/java-2d-pipeline-rendering-and-properties.htm#JSTGD428 ) and explicitly mentioning d3d=false should not make any difference that's why i have removed it.
>>
>> But i have verified updated test even with d3d=false and there are no issues. If needed i can update the test to run with d3d=false also.
>
> oh boy that doc is SO out of date.
> D3D has been the default pipeline since shortly after that doc was written !
> It was written for 6 GA and 6u10 made D3D the default.
> So if you want to be sure to disable it you DO need d3d=false ..
Hi Phil,
I was also not sure about it and tested with d3d=false, thanks for the clarification.
I have re-enabled DirectDraw/GDI run.
Even the Java SE 19 doc says DirectDraw/GDI is default on Windows : https://docs.oracle.com/en/java/javase/19/troubleshoot/java-2d-pipeline-rendering-and-properties.html#GUID-AAB8CC86-652B-4A78-83EB-CDC3F5677A48.
Thanks,
Jay
-------------
PR: https://git.openjdk.org/jdk/pull/11158
More information about the client-libs-dev
mailing list