RFR: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout [v3]

Alexander Zuev kizune at openjdk.org
Wed Nov 16 19:55:01 UTC 2022


On Wed, 16 Nov 2022 08:50:57 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> test/jdk/javax/sound/midi/Sequencer/MetaCallback.java line 119:
>> 
>>> 117:             finished = true;
>>> 118:         } else if (msg.getData().length > 0 && msg.getType() == 1 && !received.contains(msg)) {
>>> 119:             received.add(msg);
>> 
>> Do we not need to do seq.stop() before close() in l136
>
> If this code is needed can we check first where we create duplicate events?

> Do we not need to do seq.stop() before close() in l136

On that line we never call start() on the sequencer so calling stop() is redundant.

-------------

PR: https://git.openjdk.org/jdk/pull/11157



More information about the client-libs-dev mailing list