RFR: 8252713: jtreg time out of CtrlASCII.java seems to hang the Xserver.

Andrey Turbanov aturbanov at openjdk.org
Thu Nov 17 20:22:24 UTC 2022


On Thu, 17 Nov 2022 15:51:50 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> This test needs more stabilization:
> 
> - The test can be easily hang by replacing <br> iteration on `keycharHash.elements()` with `keycharHash.forEach((k, v) -> punchCtrlKey(robot, v));` 
> I do not see any reason why we need a synchronized `Hashtable`, so switched to `HashMap`
> Looks like it might be a reason of original test hanging.
> - `keyRelease`, `dispose` calls wrapped with finally block
> - Just to be safe added timeout `@run main/timeout=600` ( none of the CI test runs took too long thought)
> 
> CI testing looks good on all platforms.

test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java line 247:

> 245:         printKey(evt);
> 246:         char keych = evt.getKeyChar();
> 247:         if( !KEYCHAR_MAP.containsKey( keych ) ) {

Suggestion:

        if (!KEYCHAR_MAP.containsKey( keych )) {

-------------

PR: https://git.openjdk.org/jdk/pull/11214



More information about the client-libs-dev mailing list