RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent [v5]

Alexey Ivanov aivanov at openjdk.org
Thu Nov 17 20:45:37 UTC 2022


On Thu, 17 Nov 2022 17:24:37 GMT, ravi gupta <duke at openjdk.org> wrote:

>> This testcase Verify the content changes of a TextArea for the following assertions.
>> 
>> a. TextListener get invoked when the content of a TextArea gets changed.
>> b. TextListener not get invoked during text selection or when Special keys such as Function Keys are pressed.
>> 
>> 
>> Testing:
>> Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.
>
> ravi gupta has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8296632: Review Fixes

Marked as reviewed by aivanov (Reviewer).

test/jdk/java/awt/event/ComponentEvent/TextAreaTextEventTest.java line 56:

> 54:             robot = new Robot();
> 55:             robot.setAutoDelay(100);
> 56:             robot.setAutoWaitForIdle(true);

If you call `waitForIdle` explicitly, this may be redundant. Yet it may make the test more stable as the robot allows processing all the events before the next event is generated.

test/jdk/java/awt/event/ComponentEvent/TextAreaTextEventTest.java line 86:

> 84:             robot.waitForIdle();
> 85: 
> 86:             if (!textChanged) {

A nit: in other places, the blank line is above `waitForIdle`.

-------------

PR: https://git.openjdk.org/jdk/pull/11052



More information about the client-libs-dev mailing list