RFR: 8191406: [hidpi] sun/java2d/SunGraphics2D/DrawImageBilinear.java test fails
Jayathirth D V
jdv at openjdk.org
Fri Nov 18 06:44:51 UTC 2022
On Thu, 17 Nov 2022 17:49:09 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> This test was failing because of timing or color difference issues.
>> Updated test to:
>>
>> 1) Use EDT for UI drawing instead of manual synchronisation
>> 2) Use Robot.waitForIdle before screen capture
>> 3) Increase color tolerance delta from 1 to 5
>> 4) Use undecorated frame and explicitly set background color and move the frame to top
>> 5) Cleanup to remove not needed flags and java options
>>
>> After these changes test passes on all platforms in CI except Linux. For Linux it looks like product issue so i have raised : https://bugs.openjdk.org/browse/JDK-8297175
>
> test/jdk/sun/java2d/SunGraphics2D/DrawImageBilinear.java line 151:
>
>> 149: frame = new Frame();
>> 150: frame.add(test);
>> 151: frame.setBackground(Color.WHITE);
>
> How the specific background color helps the test to pass, as far as I understand it should not affect the test, no?
I noticed in my local Ubuntu VM that sometimes the background was not pure white and had some delta. Thats why i explicitly added background color. But looks like it is not needed and test passes all the time in CI, so i have removed it.
-------------
PR: https://git.openjdk.org/jdk/pull/11201
More information about the client-libs-dev
mailing list