RFR: 8296275: Write a test to verify setAccelerator method of JMenuItem. [v3]
Naveen Narayanan
duke at openjdk.org
Fri Nov 18 09:31:21 UTC 2022
On Thu, 17 Nov 2022 13:05:21 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Naveen Narayanan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8296275: Review comments fixed.
>
> test/jdk/java/awt/Desktop/JMenuItemSetAcceleratorTest.java line 81:
>
>> 79: try {
>> 80: if (!Desktop.isDesktopSupported()
>> 81: || !Desktop.getDesktop().isSupported(Action.APP_MENU_BAR)) {
>
> Why are you checking `APP_MENU_BAR` if you don't use it?
>
> Is the test indented for standard `JMenu` or the one that integrates with macOS menu bar?
Removed APP_MENU_BAR as we don't use it.
-------------
PR: https://git.openjdk.org/jdk/pull/11035
More information about the client-libs-dev
mailing list