RFR: 8191406: [hidpi] sun/java2d/SunGraphics2D/DrawImageBilinear.java test fails [v2]
Sergey Bylokhov
serb at openjdk.org
Tue Nov 22 03:22:05 UTC 2022
On Fri, 18 Nov 2022 06:49:38 GMT, Jayathirth D V <jdv at openjdk.org> wrote:
>> This test was failing because of timing or color difference issues.
>> Updated test to:
>>
>> 1) Use EDT for UI drawing instead of manual synchronisation
>> 2) Use Robot.waitForIdle before screen capture
>> 3) Increase color tolerance delta from 1 to 5
>> 4) Use undecorated frame and explicitly set background color and move the frame to top
>> 5) Cleanup to remove not needed flags and java options
>>
>> After these changes test passes on all platforms in CI except Linux. For Linux it looks like product issue so i have raised : https://bugs.openjdk.org/browse/JDK-8297175
>
> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove extra tolerance and background color
test/jdk/sun/java2d/SunGraphics2D/DrawImageBilinear.java line 149:
> 147: EventQueue.invokeAndWait(() -> createAndShowGUI());
> 148: } catch (Exception ex) {
> 149: ex.printStackTrace();
It will be better to halt the test at this point if the exception was thrown during UI creation.
-------------
PR: https://git.openjdk.org/jdk/pull/11201
More information about the client-libs-dev
mailing list