RFR: 8295707: Create a regression test for JDK-7184401 [v2]
Sergey Bylokhov
serb at openjdk.org
Wed Nov 23 02:11:31 UTC 2022
On Mon, 7 Nov 2022 07:28:02 GMT, Srinivas Mandalika <smandalika at openjdk.org> wrote:
>> 8295707: Create a regression test for JDK-7184401
>>
>> JDK-7184401 - JDk7u6 : Missing main menu bar in Netbeans after fix for 7162144
>> Above bug got introduced due to a fix for [JDK-7162144](https://bugs.openjdk.java.net/browse/JDK-7162144).
>> The issue was observed on the netbeans UI.
>> The test below recreates a standalone test to mimic the failure reported in Netbeans in [JDK-7184401](https://bugs.openjdk.java.net/browse/JDK-7184401) and verifies that it is working as expected after it got fixed via [JDK-7189350](https://bugs.openjdk.java.net/browse/JDK-7189350))
>>
>> The Test attempts to reproduce specific behavior of NetBeans at the certain toolbar creation stage. Widgets are created on EDT; Another code posts some events to them on EDT; From another thread some code calls explicitly edt.interrupt().
>> Before this got fixed, events from a second code got lost.
>>
>> This review is for migrating tests from a closed test suite to open.
>> Testing:
>> 1.Tested the code on jdk7u6 to reproduce the issue - the UI hangs when run on this build.
>> 2. Tested the code on jdk7u361 b01 to validate the fix - the test passed.
>> 3.Mach5 Testing(40 times per platform) in macos x64, linux x64 and windows x64 - the .results are clean
>
> Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision:
>
> Fixed Review Comments: Removed redundant code
test/jdk/java/awt/EventDispatchThread/InterruptEDTTest.java line 66:
> 64: frame.setVisible(true);
> 65: });
> 66: ((sun.awt.SunToolkit) (Toolkit.getDefaultToolkit())).realSync();
You can use the Robot.waitForIdle instead of realSync since jdk9.
test/jdk/java/awt/EventDispatchThread/InterruptEDTTest.java line 80:
> 78: });
> 79: } catch (Exception e) {
> 80: e.printStackTrace();
Why do we skip an exception here and in another place below?
-------------
PR: https://git.openjdk.org/jdk/pull/10784
More information about the client-libs-dev
mailing list