RFR: 8078471: The BACKSPACE key doesn't work with the special options"-client -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel" [v4]
Phil Race
prr at openjdk.org
Mon Nov 28 22:14:09 UTC 2022
On Sun, 27 Nov 2022 16:25:15 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> The Backspace key doesn't lead to parent directory of current directory for JFileChooser in GTK LAF.
>> Added the lazy input value in `GTKLookandFeel` and fix is working fine.
>>
>> Implemented a manual test to check BackSpace behavior for all installed LAF in Linux platform.
>> The test mentioned in [JDK-8078471](https://bugs.openjdk.org/browse/JDK-8078471) `javax/swing/JFileChooser/4150029/bug4150029.html` also working fine with GTK option (-client -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel).
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> Whitespace error fix
Please split the long line before pushing.
Also you'll probably need to update the PR to match the new bug summary.
ALWAYS consider if a bug summary is well written as part of the bug evaluation
test/jdk/com/sun/java/swing/plaf/gtk/TestBackSpaceAction.java line 75:
> 73: subDir = new File(testDir, "subDir");
> 74: subDir.mkdir();
> 75: subDir.deleteOnExit();
To my surprise, this should be OK. The spec says
"Files (or directories) are deleted in the reverse order that they are registered."
-------------
Marked as reviewed by prr (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11291
More information about the client-libs-dev
mailing list