RFR: 8165943: LineBreakMeasurer does not measure correctly if TextAttribute.TRACKING is set.
Phil Race
prr at openjdk.org
Tue Nov 29 23:04:31 UTC 2022
On Thu, 15 Sep 2022 16:51:27 GMT, Olga Mikhaltsova <omikhaltcova at openjdk.org> wrote:
> This is a fix for LineBreakMeasurer. It takes into account the TextAttribute.TRACKING value (not eq 0) while calculating the line breaks.
>
> Tested on Linux x64, Windows x64, macOS x64 with the reproducer (LineBreakSample.java) attached to JDK-8165943 and the following group of tests:
> `$JTREG_HOME/bin/jtreg -jdk:$BUILD_HOME ./test/jdk/java/awt/font`
I'm sure an automated test is possible - it should be easy enough to adjust the tracking and verify the breaks are different.
The code paths here don't do complex text. Tracking doesn't really work for things like Arabic .. but it would be good to
verify that Arabic measures as it lays out with tracking - ignoring it I expect, but I could be surprised if there's something I am overlooking. Hence why a test of that would be good.
-------------
PR: https://git.openjdk.org/jdk/pull/10289
More information about the client-libs-dev
mailing list