RFR: JDK-8015739: Background of JInternalFrame is located out of JInternalFrame [v4]

Alisen Chung achung at openjdk.org
Tue Oct 4 18:40:25 UTC 2022


On Mon, 3 Oct 2022 22:29:06 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBorders.java line 336:
>> 
>>> 334:                 // Draw the Long highlight lines
>>> 335:                 g.setColor(highlight);
>>> 336:                 g.drawLine(scaledCorner + 1, midPoint+stkWidth,
>> 
>> The spacing here and when drawing shadow lines is a bit inconsistent
>
> @alisenchung  I tried by increasing and decreasing the line position a bit, the current combination provided optimal positioning of both the shadow and highlight line within the border for all the scales. The slight inconsistency in spacing is probably due to rounding losses in loop count, stroke width and corner. I'll check it again.

Oh, I meant the actual code spacing, theres a space between scaledCorner and 1, but not space between midPoint and stkWidth

-------------

PR: https://git.openjdk.org/jdk/pull/10274



More information about the client-libs-dev mailing list