RFR: JDK-8015739: Background of JInternalFrame is located out of JInternalFrame [v6]
Alexey Ivanov
aivanov at openjdk.org
Tue Oct 4 21:34:38 UTC 2022
On Tue, 4 Oct 2022 20:37:35 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> JInternalFrame background color seems to overflow into the border region. This issue is more prominently seen on Windows - Metal LAF (with fractional scaling, as shown below). The primary reason is border scaling issue as observed in - [JDK-8279614](https://bugs.openjdk.org/browse/JDK-8279614)
>>
>> The fix involves a similar approach as described here https://github.com/openjdk/jdk/pull/7449#issuecomment-1068218648. The test checks the midpoint and corners of borders to check if the internal frame's background color is located out of JInternalFrame.
>>
>> 
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>
> MRI changes
test/jdk/javax/swing/JInternalFrame/InternalFrameBorderTest.java line 256:
> 254: } else {
> 255: nativeResImage = resolutionVariants.get(0);
> 256: }
Suggestion:
RenderedImage image = (RenderedImage) resolutionVariants.get(resolutionVariants.size() > 1 ? 1 : 0);
or rather simpler:
Suggestion:
RenderedImage image = (RenderedImage) resolutionVariants.get(resolutionVariants.size() - 1);
-------------
PR: https://git.openjdk.org/jdk/pull/10274
More information about the client-libs-dev
mailing list