RFR: JDK-8015739: Background of JInternalFrame is located out of JInternalFrame [v5]

Alexey Ivanov aivanov at openjdk.org
Wed Oct 5 17:06:28 UTC 2022


On Tue, 4 Oct 2022 19:39:23 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review changes, saving a scaled version of image
>
> test/jdk/javax/swing/JInternalFrame/InternalFrameBorderTest.java line 229:
> 
>> 227:         jFrame.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);
>> 228: 
>> 229:         JLabel scale = new JLabel("UI Scale: "+ uiScale);
> 
> Suggestion:
> 
>         JLabel scale = new JLabel("UI Scale: " + uiScale);

The space is still missing before `+`. Yes, there's space inside the string literal but it's inside, binary operators should still have spaces on either side.

-------------

PR: https://git.openjdk.org/jdk/pull/10274



More information about the client-libs-dev mailing list