RFR: JDK-6229853: BasicTextAreaUI:create incompletely documents the possible returned View types [v4]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Fri Oct 7 04:57:03 UTC 2022
On Wed, 28 Sep 2022 12:23:59 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> javadoc fix
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextFieldUI.java line 86:
>
>> 84:
>> 85: /**
>> 86: * Creates a view based on an element.
>
> Should we use the wording from `BasicTextUI` for consistency?
>
> Suggestion:
>
> * Creates a view for an element.
>
>
> The description in [`ViewFactory.create`](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/text/ViewFactory.html#create(javax.swing.text.Element)) is more detailed, a short sentence as above is enough for `TextUI`.
Seems ok for consistency..
Have updated the PR and CSR...Can you please review CSR https://bugs.openjdk.org/browse/JDK-8294114
-------------
PR: https://git.openjdk.org/jdk/pull/10376
More information about the client-libs-dev
mailing list