RFR: 6777156: GTK L&F: JFileChooser can jump beyond root directory in combobox and selection textarea. [v3]
Jayathirth D V
jdv at openjdk.org
Tue Oct 11 06:52:41 UTC 2022
On Tue, 11 Oct 2022 06:42:37 GMT, Abhishek Kumar <duke at openjdk.org> wrote:
>> When a user selects ../ from directory list in GTK FileChooser continuosly, it leads to '../../../.....' in combobox and selection textarea even though it the current directory is at root level.
>>
>> Fix for the issue is to remove "../" entry from JFileChooser directory list in GTK LAF if current directory is root.
>>
>> Test case has been added and checked in CI pipeline. Link is attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comment fix and test case changed to manual
Its good that now we are handling entries in directory list at appropriate place instead of modifying it at some event listeners. LGTM.
-------------
Marked as reviewed by jdv (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10390
More information about the client-libs-dev
mailing list