RFR: 6777156: GTK L&F: JFileChooser can jump beyond root directory in combobox and selection textarea. [v3]

Abhishek Kumar duke at openjdk.org
Tue Oct 11 07:10:32 UTC 2022


On Tue, 11 Oct 2022 07:02:18 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment fix and test case changed to manual
>
> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChooserUI.java line 997:
> 
>> 995:             File crntDir = getFileChooser().getCurrentDirectory();
>> 996:             if (crntDir != null && crntDir.getParentFile() == null &&
>> 997:                 files.contains(new File("/.."))) {
> 
> Is it not possible to use "FileSystemView.isFileSystemRoot(File)" for this?

I have not checked this.
Do you mean to check `FileSystemView.isFileSystemRoot(crntDir )` ?

-------------

PR: https://git.openjdk.org/jdk/pull/10390



More information about the client-libs-dev mailing list