RFR: 6777156: GTK L&F: JFileChooser can jump beyond root directory in combobox and selection textarea. [v4]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Tue Oct 11 09:57:35 UTC 2022
On Tue, 11 Oct 2022 09:10:10 GMT, Abhishek Kumar <duke at openjdk.org> wrote:
>> When a user selects ../ from directory list in GTK FileChooser continuosly, it leads to '../../../.....' in combobox and selection textarea even though it the current directory is at root level.
>>
>> Fix for the issue is to remove "../" entry from JFileChooser directory list in GTK LAF if current directory is root.
>>
>> Test case has been added and checked in CI pipeline. Link is attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comment fix
test/jdk/javax/swing/JFileChooser/TestFileChooserDirectorySelection.java line 34:
> 32: * @run main/manual TestFileChooserDirectorySelection
> 33: */
> 34:
better to put the test in plaf/gtk folder as it fixed gtk issue
-------------
PR: https://git.openjdk.org/jdk/pull/10390
More information about the client-libs-dev
mailing list