RFR: 7175397: The divider color is not changed to green when dragging for Nimbus LaF. [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Oct 17 06:11:18 UTC 2022


On Wed, 28 Sep 2022 12:01:18 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert default value
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthSplitPaneUI.java line 273:
> 
>> 271:                 paintDragDivider(g, 0, 0, getWidth(), getHeight());
>> 272:                 if(!isContinuousLayout() && getLastDragLocation() != -1) {
>> 273:                     Dimension      size = splitPane.getSize();
> 
> We can eliminate creation on new variable and use splitPane.getWidth/Height() as it is done at many places in this file.

ok..removed..

> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthSplitPaneUI.java line 366:
> 
>> 364:         if(jc == splitPane && getLastDragLocation() != -1 &&
>> 365:                               !isContinuousLayout() && !draggingHW) {
>> 366:             Dimension      size = splitPane.getSize();
> 
> Same here

ok..removed...

-------------

PR: https://git.openjdk.org/jdk/pull/9937



More information about the client-libs-dev mailing list