RFR: 8295298: Automate javax/swing/JFileChooser/FileViewNPETest.java

Sergey Bylokhov serb at openjdk.org
Thu Oct 20 23:29:46 UTC 2022


On Thu, 20 Oct 2022 19:31:27 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> The automated test follows the instructions of the manual test that was added in #10485.
> 
> Instead of selecting the parent folder from the **Look in** combo box, it calls `setCurrentDirectory` directly with the parent of the path which is not traversable. Thus, the current directory of the file chooser is set to `null`.
> 
> As the second step, the test finds the combo box and re-selects the currently selected element. Without the fix for [JDK-6616245](https://bugs.openjdk.org/browse/JDK-6616245), `NullPointerException` is thrown and the test fails; with the fix applied, the original folder is selected and the test passes.
> 
> @mrserb and @TejeshR13, please, take a look.

test/jdk/javax/swing/JFileChooser/FileViewNPETest.java line 62:

> 60:             SwingUtilities.invokeAndWait(() -> {
> 61:                 jfc.setCurrentDirectory(path.getParentFile());
> 62:                 assert jfc.getCurrentDirectory() == null

This assertion could be skipped if the test executed standalone or via directly by the jtreg w/o makefiles.

-------------

PR: https://git.openjdk.org/jdk/pull/10801



More information about the client-libs-dev mailing list