RFR: 8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java [v2]
Alexey Ivanov
aivanov at openjdk.org
Fri Oct 21 11:37:06 UTC 2022
On Thu, 20 Oct 2022 23:37:41 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> Alexey Ivanov has updated the pull request incrementally with four additional commits since the last revision:
>>
>> - Set the locale to US
>> - Adjust wrapping for error message
>> - Use local variable to store first error message
>> - Shorter error message
>
> test/jdk/javax/swing/JFileChooser/FileSizeCheck.java line 158:
>
>> 156: robot.waitForIdle();
>> 157: robot.delay(500);
>> 158: SwingUtilities.invokeAndWait(FileSizeCheck::clickDetails);
>
> Can we click that button programmatically w/o robot? That will make the test a little bit more stable.
It is clicked programmatically. https://github.com/openjdk/jdk/blob/1dc4e2b6279f2c0b3180d448c1ce688475c9b025/test/jdk/javax/swing/JFileChooser/FileSizeCheck.java#L221
Robot is used only for `waitForIdle` to ensure events are processed.
-------------
PR: https://git.openjdk.org/jdk/pull/10802
More information about the client-libs-dev
mailing list