RFR: 8295298: Automate javax/swing/JFileChooser/FileViewNPETest.java [v2]

Sergey Bylokhov serb at openjdk.org
Fri Oct 21 19:18:54 UTC 2022


On Fri, 21 Oct 2022 16:10:17 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> The automated test follows the instructions of the manual test that was added in #10485.
>> 
>> Instead of selecting the parent folder from the **Look in** combo box, it calls `setCurrentDirectory` directly with the parent of the path which is not traversable. Thus, the current directory of the file chooser is set to `null`.
>> 
>> As the second step, the test finds the combo box and re-selects the currently selected element. Without the fix for [JDK-6616245](https://bugs.openjdk.org/browse/JDK-6616245), `NullPointerException` is thrown and the test fails; with the fix applied, the original folder is selected and the test passes.
>> 
>> @mrserb and @TejeshR13, please, take a look.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Convert asserts to explicit checks

Marked as reviewed by serb (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/10801



More information about the client-libs-dev mailing list