RFR: 8295248: JEditorPane HTML form with multi selection broke drawing after reseting [v3]

Phil Race prr at openjdk.org
Mon Oct 24 04:30:45 UTC 2022


On Mon, 24 Oct 2022 02:06:23 GMT, Toshio Nakamura <tnakamura at openjdk.org> wrote:

>> When JEditorPane shown HTML form with multi-selection, the reset operation broke its drawing.
>> 
>> There are two issues. The current method `OptionListModel.removeIndexInterval()` disabled selections, but it didn't fire the change. Then, no re-drawing. Another issue is the method works as remove and shift. Then, selection values were corrupted.
>> I think the clear method `OptionListModel.clearSelection()` is suitable here.
>> 
>> Test: jdk_desktop on macOS (x64, Monterey), Linux (x64, RHEL8), and Windows (x64, 2012R2).
>>       No regression found
>
> Toshio Nakamura has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed space

Can you try again to describe the issue ? 
The bug summary is misleading I'm sure. "Drawing" as in RENDERING is NOT broken.
I think you are trying to say something about expectations for what item(s) are selected .. 
Perhaps what is missing is a PROPER explanation of what you think reset and submit should do and so forth.
And this looks like one of those "tiny" changes which are "completely harmless" but you have said NOTHING about what wider testing you've done on other cases. Fix one case != make things uniformly better ..

-------------

PR: https://git.openjdk.org/jdk/pull/10685



More information about the client-libs-dev mailing list