RFR: 6972078: Can not select single directory with GTKLookAndFeel [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Oct 27 04:04:33 UTC 2022


On Wed, 26 Oct 2022 16:26:33 GMT, Abhishek Kumar <duke at openjdk.org> wrote:

>> While using a JFileChooser with the file selection mode FILES_AND_DIRECTORIES and multiSelection enabled, it is impossible to select a single directory in GTK LAF.
>> 
>> The condition check has been modified when multiselection is enabled and user has selected single directory.
>> After the fix the behavior of JFileChooser is similar to other LAFs.
>> 
>> An automatic test case `test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirectorySelection.java` is implemented and checked in CI pipeline. Link is attached in JBS.
>
> Abhishek Kumar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Review comment fix
>  - Merge
>  - Whitespace error fix
>  - Single directory selection fix

Can you also please test it works ok (or atleast not regress) for other selection mode FILES_ONLY, DIRECTORIES_ONLY in the test?

> After the fix the behavior of JFileChooser is similar to other LAFs.

Can you then please enhance the test to iterate for all installed L&Fs?

-------------

PR: https://git.openjdk.org/jdk/pull/10866



More information about the client-libs-dev mailing list