RFR: 6257207: JTable.getDefaultEditor throws NullPointerException [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Oct 31 09:11:21 UTC 2022


> If getDefaultEditor() is called before the JTable model is setup, it results in NPE.
> 
> This is because when JTable sets its model, which ends up firing a table changed event. The testcase is listening for tableChanged events and querying the editor. But the editor isn't installed until after the model is set which results in NPE.
> Fix is to ensure initializeLocalVars() which initializes default editor is setup before JTable sets its model.
> 
> No regression is observed in jtreg/jck testsuite with this change.

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Review fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10871/files
  - new: https://git.openjdk.org/jdk/pull/10871/files/e2e5c38d..58c36915

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10871&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10871&range=00-01

  Stats: 268 lines in 2 files changed: 136 ins; 132 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/10871.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10871/head:pull/10871

PR: https://git.openjdk.org/jdk/pull/10871



More information about the client-libs-dev mailing list