RFR: 4834298: JFileChooser.getSelectedFiles() failed with multi-selection and double-click

Andrey Turbanov aturbanov at openjdk.org
Thu Sep 1 06:28:11 UTC 2022


On Wed, 24 Aug 2022 07:44:52 GMT, Tejesh R <tr at openjdk.org> wrote:

> JFileChooser.getSelectedFiles() failed to retrieve files with multi-selection and double-click. This occurs when a single file is selected then enable multi-selection then select the same file through mouse double-click(Two file chooser dialogs used before and after multi-selection enabled). SelectedFiles are updated when a change in files/directory selection is done or when selection is made through keyboard selection. In this case since a single file is selected before multi-selection is enabled and same file is selected again without changing the selection index/directory, leaving selected Files un-updated. 
> **Proposed Fix** : Whenever Multi-Selection is enabled check if any files are selected, if yes update the selected Files of JFileChoooser.

src/java.desktop/share/classes/sun/swing/FilePane.java line 1760:

> 1758:             //If selected, retain them and update the selected files in FileChooser class.
> 1759:             File[] selectedFiles = null;
> 1760:             if(getFileChooser().getSelectedFiles().length != 0) {

let's add space after `if`s

-------------

PR: https://git.openjdk.org/jdk/pull/9996



More information about the client-libs-dev mailing list