RFR: 8287912: GTK L&F : Background of tree icons are red [v2]

Abhishek Kumar duke at openjdk.org
Fri Sep 2 07:23:43 UTC 2022


On Fri, 2 Sep 2022 06:11:47 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review Comments fix
>
> test/jdk/javax/swing/JTree/TestTreeBackgroundColor.java line 84:
> 
>> 82:                 }
>> 83:             }
>> 84:             if (!passed) {
> 
> This test will pass even in the case of last pixel check is RED. We should check for pixel data and whenever it is not RED we should bail out.
> 
> Also if test fails it will leave TreeBackgroundColorTestFail.png, we should use temporary file and delete it on exit.

I have removed the writing of test image in case of fail operation and test condition changed to check if pixel color is not red then test will fail.

-------------

PR: https://git.openjdk.org/jdk/pull/10112



More information about the client-libs-dev mailing list