RFR: 8287912: GTK L&F : Background of tree icons are red [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Sep 5 07:11:39 UTC 2022


On Mon, 5 Sep 2022 07:06:40 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> The test check has been changed to compare the pixels of entire width keeping the height constant to half of tree height. Now it will check pixel color and if it is not red , the test will fail.
>
> For me, test is not failing without the fix.
> Also, if you test entire width and fail if it is not red, it might encounter black pixel of text font too and might fail, so I think it's better to check width/2 to width -1 and not entire width.

Also, it's might be better to write the image in case of failure so that it gives an idea why it failed.

-------------

PR: https://git.openjdk.org/jdk/pull/10112



More information about the client-libs-dev mailing list