RFR: 8292848: AWT_Mixing and TrayIcon tests fail on el8 with hard-coded isOel7

KIRIYAMA Takuya duke at openjdk.org
Mon Sep 5 09:35:34 UTC 2022


On Thu, 25 Aug 2022 18:56:59 GMT, Phil Race <prr at openjdk.org> wrote:

>> Could you please review the JDK-8292848 bug fixes?
>> The purpose of the isOel7 method is to detect differences in GNOME version changes, and the isOel7 
>> result should be true after version 8.
>> I modified the isOel7 method to use regular expressions instead of hard-coded versions to be able to 
>> detect the new os version.
>> I also changed the method name to match the new conditions.
>
> I guess this will do what was previously being done on OL7 .. but the way it is done it is fragile
> and surely it can't be specific to OL .. and there's some pretty hokey adjustments going on in some of these tests.
> I think some day these tests will need to be re-examined.

@prrace 
Thank you for your review. I agree with another consideration .

I think two reviews are required thisfix to be integrated. Could anyone please review this fix?

-------------

PR: https://git.openjdk.org/jdk/pull/9995



More information about the client-libs-dev mailing list