RFR: 6852577: Only for Nimbus LAF UIManager.get("PasswordField.echoChar") is null [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Sep 6 07:00:44 UTC 2022


On Tue, 6 Sep 2022 06:33:14 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removal of Nimbus L&F hardcode
>
> test/jdk/javax/swing/plaf/nimbus/PasswordFieldTest.java line 56:
> 
>> 54:             if (UIManager.get("PasswordField.echoChar") == null) {
>> 55:                 throw new RuntimeException(
>> 56:                     "PasswordField.echoChar returns null for NimbusL&F");
> 
> Hardcoding of NimbusL&F for exception string can be replaced with L&F name. Since the traversal is happening for all L&F, expecting only Nimbus might not be right I guess.

yes, removed since we are already printing the L&F being tested in the beginning.

-------------

PR: https://git.openjdk.org/jdk/pull/10035



More information about the client-libs-dev mailing list