RFR: 4834298: JFileChooser.getSelectedFiles() failed with multi-selection and double-click [v2]

[Tejesh R]

On Tue, 6 Sep 2022 11:07:09 GMT, Abhishek Kumar <duke at openjdk.org> wrote:

> I guess copyright year for FilePane.java needs to be updated.

Updated.

> src/java.desktop/share/classes/sun/swing/FilePane.java line 1763:
> 
>> 1761:                 selectedFiles = getFileChooser().getSelectedFiles();
>> 1762:             } else if (getFileChooser().getSelectedFile() != null) {
>> 1763:                 File selectedFile = getFileChooser().getSelectedFile();
> 
> File selectedFile = getFileChooser().getSelectedFile();
> selectedFiles = new File[1];
> selectedFiles[0] = selectedFile;
> 
> You can directly assign getFileChooser().getSelectedFile() value to selectedFiles[0]. I think no need to create extra selectedFile variable.

Updated.

> test/jdk/javax/swing/JFileChooser/MultiSelectionEnabledSelectedFilesTest.java line 87:
> 
>> 85:         File[] files = chooser.getSelectedFiles();
>> 86: 
>> 87:         if(files.length <= 0) {
> 
> `if(files.length <= 0) {`
> 
> Please add space after if.

Updated.

-------------

PR: https://git.openjdk.org/jdk/pull/9996