RFR: 7175397: The divider color is not changed to green when dragging for Nimbus LaF. [v2]
Damon Nguyen
dnguyen at openjdk.org
Wed Sep 7 06:21:48 UTC 2022
On Wed, 24 Aug 2022 04:21:26 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> SplitPaneDivider.draggingColor UIProperty was not honoured in Nimbus L&F.
>> Added support for setting SplitPane dragging color for Nimbus L&F by drawing a fillRect of the set color as done in BasicLookAndFeel.
>> The fix relies on `continuousLayout` property being false by default which is enabled for Nimbus, which is set to default false now, same as in other L&F. I think it was set true just to have documented default value in JDK-6937415
>>
>> closed test mentioned in JBS is used for fix check.
>> All jtreg swing tests are ok along with SwingSet2 JSplitPane demo in Nimbus L&F.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Revert default value
Changes requested by dnguyen (Author).
src/java.desktop/share/classes/javax/swing/plaf/synth/SynthSplitPaneUI.java line 369:
> 367:
> 368: g.setColor(dividerDraggingColor);
> 369: if(jc.getOrientation() == JSplitPane.HORIZONTAL_SPLIT) {
I know these if's already existed, but now might be a good time to also update these by adding a space after the if's to match the space after the else?
-------------
PR: https://git.openjdk.org/jdk/pull/9937
More information about the client-libs-dev
mailing list