RFR: 8293478: [java.desktop/macOS] Condense SDRenderType usages in QuartzRenderer.m
SWinxy
duke at openjdk.org
Wed Sep 7 18:59:38 UTC 2022
On Mon, 5 Sep 2022 23:41:40 GMT, SWinxy <duke at openjdk.org> wrote:
> The `SDRenderType` enum is often returned using a variable declared at the start of functions. These can be inlined in the `return` itself. Using a ternary operator condenses what may be 12 lines into one, in the most extreme cases. `doRectUsingCG` and `doPolyUsingCG` were both modified more than the rest, but still are equivalent.
>
> Example change:
>
> SDRenderType renderType = SD_Nothing;
>
> if (fill == YES)
> {
> renderType = SD_Fill;
> }
> else
> {
> renderType = SD_Stroke;
> }
>
> // ...
>
> return renderType;
>
>
>
> // ...
>
> return fill ? SD_Fill : SD_Stroke;
Much thanks. I forgot that the bot just *immediately* requests a review when there's a bug in the title.
-------------
PR: https://git.openjdk.org/jdk/pull/10174
More information about the client-libs-dev
mailing list