RFR: 4834298: JFileChooser.getSelectedFiles() failed with multi-selection and double-click [v3]
Tejesh R
tr at openjdk.org
Fri Sep 9 08:12:50 UTC 2022
On Thu, 8 Sep 2022 09:51:57 GMT, Jayathirth D V <jdv at openjdk.org> wrote:
>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/javax/swing/JFileChooser/MultiSelectionEnabledSelectedFilesTest.java line 56:
>
>> 54: static void runTest() {
>> 55: //Initialize the components
>> 56: String INSTRUCTIONS
>
> Instruction should be updated to specify that we need to use double-click.
> Also when i select a file using double click in first and then select same file using double-click(without moving mouse) test doesnt exit. JFileChooser second dialog just stays on the screen.
Updated.
> test/jdk/javax/swing/JFileChooser/MultiSelectionEnabledSelectedFilesTest.java line 87:
>
>> 85: File[] files = chooser.getSelectedFiles();
>> 86:
>> 87: if (files.length <= 0) {
>
> Can File[] length be negative? I think just a "==" to "0" check should suffice.
Updated.
-------------
PR: https://git.openjdk.org/jdk/pull/9996
More information about the client-libs-dev
mailing list