RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v27]

Abhishek Kumar duke at openjdk.org
Tue Sep 13 13:45:50 UTC 2022


On Mon, 12 Sep 2022 10:40:35 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments fix
>
> src/java.desktop/share/classes/sun/swing/FilePane.java line 59:
> 
>> 57: import java.io.FileNotFoundException;
>> 58: import java.text.DateFormat;
>> 59: import java.text.DecimalFormat;
> 
> `DecimalFormat` has become unused.

Updated.

> src/java.desktop/share/classes/sun/swing/FilePane.java line 1212:
> 
>> 1210:                 if (listViewWindowsStyle) {
>> 1211:                     updateMessageFormatPattern(kiloByteString);
>> 1212:                     displayedFileSize[0] = roundToOneDecimalPlace(len);
> 
> Does it correctly display the file sizes when `listViewWindowsStyle` is `true`?

Yeah, it will show file size is KB.

-------------

PR: https://git.openjdk.org/jdk/pull/9327



More information about the client-libs-dev mailing list