RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v28]
Abhishek Kumar
duke at openjdk.org
Thu Sep 15 07:26:02 UTC 2022
On Wed, 14 Sep 2022 21:33:03 GMT, Phil Race <prr at openjdk.org> wrote:
> Rounding to the nearest 0.1KB (or 0.1Mb ?) doesn't work well if it causes you to round the size down to zero. If I am understanding the thread correctly, the native chooser ducks this by displaying the exact byte count for < 1,000 - no rounding either up or down. So if we wanted to round to nearest for > 1KB we'd need to do the same - correct ? But we'd decided (due to localization issues) to just always use Kb not byte, or bytes ..
>
> So leaving aside what the native chooser does, we then just have to be consistent and round up.
>
> That's what the current version is trying to do isn't it ?
>
> Thoughts ?
Yeah, as per the current fix we are doing consistently round up for all file sizes.
-------------
PR: https://git.openjdk.org/jdk/pull/9327
More information about the client-libs-dev
mailing list