Integrated: 8292948: JEditorPane ignores font-size styles in external linked css-file

[Stanimir Stamenkov]

On Sat, 27 Aug 2022 08:54:41 GMT, Stanimir Stamenkov <duke at openjdk.org> wrote:

> [JDK-8292948] reveals a regression by the fix for [JDK-8257664] (#1759) causing `font-size` declarations from external style sheets to be ignored.
> 
> As far as I've traced, the problem is with the `isDefined(CSS.Attribute.FONT_SIZE)` test:
> 
> https://github.com/openjdk/jdk/blob/70b5b3119b2ed032b021a080f34a4fa28d092fb5/src/java.desktop/share/classes/javax/swing/text/html/StyleSheet.java#L2825-L2830
> 
> It misses declarations from linked styles via a `resolver` ([`AttributeSet.ResolveAttribute`](https://github.com/openjdk/jdk/blob/b0e0b87891eb81c2b33c1cfa598701b7bd2e5bdf/src/java.desktop/share/classes/javax/swing/text/AttributeSet.java#L187-L191)) attribute that happens to hold the external style sheet rules.  The fix for this would be to move the implied `CSS.Attribute.FONT_SIZE` handling after:
> 
> https://github.com/openjdk/jdk/blob/70b5b3119b2ed032b021a080f34a4fa28d092fb5/src/java.desktop/share/classes/javax/swing/text/html/StyleSheet.java#L2833-L2835
> 
> and drop the `isDefined()` test.
> 
> [I'll prepare a jtreg test further.]
> 
> [JDK-8292948]: https://bugs.openjdk.org/browse/JDK-8292948 "JEditorPane ignores font-size styles in external linked css-file"
> [JDK-8257664]: https://bugs.openjdk.org/browse/JDK-8257664 "HTMLEditorKit: Wrong CSS relative font sizes"

This pull request has now been integrated.

Changeset: 1caba0f1
Author:    Stanimir Stamenkov <stanio at yahoo.com>
Committer: Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/1caba0f13c42121c9e1c6648715ec7c31349b537
Stats:     217 lines in 4 files changed: 211 ins; 4 del; 2 mod

8292948: JEditorPane ignores font-size styles in external linked css-file

Reviewed-by: psadhukhan

-------------

PR: https://git.openjdk.org/jdk/pull/10054