Integrated: 8054572: [macosx] JComboBox paints the border incorrectly

Damon Nguyen dnguyen at openjdk.org
Mon Sep 19 11:36:37 UTC 2022


On Tue, 12 Jul 2022 18:16:06 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> When a JComboBox is editable, the button segment of the combo box is misaligned vertically and has a different height. This change fixes these issues and adds a manual test that checks the appearance of an editable and non-editable JComboBox.
> 
> One of the discussions revolving this issue is the native macOS appearance of editable JComboBoxes. After looking through native macOS apps, the only one found is in System Preferences > Date & Time. The problem here is that the native equivalent found here uses a blue button with a single down arrow as the button's symbol. The current swing implementation uses a white button with an up & down arrow symbol for the button. A JRS widget button that has this blue button with a single downward arrow exists but does not support text fields.
> 
> As such, I believe the best fix for this issue is to mainly fix the alignment and sizing issue. I looked through Apple's documentation for these UI elements but editable JComboBoxes aren't specifically listed anywhere. Similarly, there's barely any editable JComboBoxes used in native mac apps (only the date & time). So, I don't think it's a major issue if JComboBox does not exactly match the example found in Date & Time.

This pull request has now been integrated.

Changeset: 8082c24a
Author:    Damon Nguyen <dnguyen at openjdk.org>
Committer: Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/8082c24a0df3f4861ea391266bdfe6cdd1a77bab
Stats:     123 lines in 2 files changed: 120 ins; 2 del; 1 mod

8054572: [macosx] JComboBox paints the border incorrectly

Reviewed-by: honkar, psadhukhan

-------------

PR: https://git.openjdk.org/jdk/pull/9473



More information about the client-libs-dev mailing list