RFR: JDK-8015739: Background of JInternalFrame is located out of JInternalFrame [v2]
Harshitha Onkar
honkar at openjdk.org
Wed Sep 21 18:22:29 UTC 2022
On Wed, 21 Sep 2022 18:03:08 GMT, Stanimir Stamenkov <duke at openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>>
>> - Merge branch 'master' into JIFBorder_8015739
>> - added test summary
>> - updated test case
>> - Added test case, minor position changes to shadow lines
>> - expanded imports
>> - JIF Metal Border Scaling - Initial changes
>
> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBorders.java line 313:
>
>> 311:
>> 312: // border and corner scaling
>> 313: corner = (int) Math.round(corner * at.getScaleX());
>
> I'm likely missing something from the big picture but wouldn't this accumulate on every `paintBorder()` invocation (into a static field)?
@stanio Hi, @azuev-java did bring up the same point earlier - https://github.com/openjdk/jdk/pull/10274#discussion_r974609469. In the recent commit, I have update the code to use a different local variable - `scaledCorner` to compute and store the scaled value for each new instance.
-------------
PR: https://git.openjdk.org/jdk/pull/10274
More information about the client-libs-dev
mailing list