RFR: 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different [v4]

[Harshitha Onkar]

On Mon, 19 Sep 2022 23:24:45 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> On Windows, the insets obtained for a Non-Resizable AWT Frame was different when frame.pack() was called and subsequent call to frame.getInsets() or frame.getPreferredSize(). Due to this, the actual and preferred size differed when frame.pack() was called for Non-Resizable frame (on Windows).  
>> 
>> Earlier the insets returned when frame.getInsets() was called, was that of a Resizable frame and not the correct insets associated with Non-Resizable frame. Fix is added to native code to get the correct insets. The test - AwtFramePackTest.java has been updated to test actual and expected/preferred size for both Resizable and Non-Resizable Frames.
>> 
>> The test is generic though the issue and fix is on Windows platform because the condition 
>> `frame.getSize() == frame.getPreferredSize()` should be true on all platforms when frame.pack() is called.
>> 
>> Following is the link to Windows System Metrics (used for native insets) - https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getsystemmetrics
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   reverted the changes related to previous fix - checking the type of target object

Additionally `extraBottomInsets` variable which is initialized to zero from the start, does not seem to change anything and can be removed as part of this PR changes. https://github.com/openjdk/jdk/blob/e1958971c95a651da9e7fca7a98828f7fd0391bb/src/java.desktop/windows/native/libawt/windows/awt_Window.cpp#L1391

-------------

PR: https://git.openjdk.org/jdk/pull/9954