RFR: 8285306: Fix typos in java.desktop [v10]

SWinxy duke at openjdk.org
Thu Sep 22 01:31:33 UTC 2022


On Wed, 21 Sep 2022 11:52:57 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> I ran `codespell` on the `src/java.desktop` directory, and accepted those changes where it indeed discovered real typos.
>> 
>> I ignored typos in public methods and variables. Maybe they can be fixed later on without much fanfare, if they are in internal classes. Typos in exposed APIs are likely here to stay.
>> 
>> I will update copyright years using a script before pushing (otherwise like every second change would be a copyright update, making reviewing much harder).
>> 
>> The long term goal here is to make tooling support for running `codespell`. The trouble with automating this is of course all false positives. But before even trying to solve that issue, all true positives must be fixed. Hence this PR.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 49 commits:
> 
>  - Merge branch 'master' into typos-in-java.desktop
>  - Revert changes to glext.h
>  - Revert changes to multiVis.c and wsutils.h
>  - Merge branch 'master' into typos-in-java.desktop
>  - Revert changes in libjpeg
>  - Revert changes in libfreetype
>  - Update src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java
>    
>    Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>  - Update src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java
>    
>    Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>  - Update src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java
>    
>    Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>  - Update src/java.desktop/share/classes/sun/swing/SwingUtilities2.java
>    
>    Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>  - ... and 39 more: https://git.openjdk.org/jdk/compare/cddd6def...2850610d

src/java.desktop/share/classes/javax/swing/plaf/metal/MetalTheme.java line 68:

> 66: public abstract class MetalTheme {
> 67: 
> 68:     // Constants identifying the various Fonts that a Theme can support

I think this is possibly meant to say "constants that *our* theme can support"?

-------------

PR: https://git.openjdk.org/jdk/pull/8328



More information about the client-libs-dev mailing list