RFR: 8293478: [java.desktop/macOS] Condense SDRenderType usages in QuartzRenderer.m [v2]
SWinxy
duke at openjdk.org
Thu Sep 22 15:21:14 UTC 2022
On Thu, 8 Sep 2022 05:23:40 GMT, SWinxy <duke at openjdk.org> wrote:
>> The `SDRenderType` enum is often returned using a variable declared at the start of functions. These can be inlined in the `return` itself. Using a ternary operator condenses what may be 12 lines into one, in the most extreme cases. `doRectUsingCG` and `doPolyUsingCG` were both modified more than the rest, but are still basically the same.
>>
>> Example change:
>>
>> SDRenderType renderType = SD_Nothing;
>>
>> if (fill == YES)
>> {
>> renderType = SD_Fill;
>> }
>> else
>> {
>> renderType = SD_Stroke;
>> }
>>
>> // ...
>>
>> return renderType;
>>
>>
>>
>> // ...
>>
>> return fill ? SD_Fill : SD_Stroke;
>
> SWinxy has updated the pull request incrementally with one additional commit since the last revision:
>
> We can do this here, too
Hi mailing list, would anyone kindly review this patch?
-------------
PR: https://git.openjdk.org/jdk/pull/10174
More information about the client-libs-dev
mailing list