RFR: 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different [v4]

[Harshitha Onkar]

On Thu, 22 Sep 2022 17:09:07 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   reverted the changes related to previous fix - checking the type of target object
>
> src/java.desktop/windows/native/libawt/windows/awt_Window.cpp line 1419:
> 
>> 1417:                 ::GetSystemMetrics(SM_CXSIZEFRAME) + extraPaddedBorderInsets;
>> 1418:             m_insets.top = m_insets.bottom =
>> 1419:                 ::GetSystemMetrics(SM_CYSIZEFRAME) + extraPaddedBorderInsets;
> 
> Is it worth adding a comment clarifying why the style isn't checked? Maybe not, since now it's gone from the code. On the other hand, a reader may wonder why we always uses the sizing frame insets even for non-resizeable frames.

@aivanov-jdk I agree, comment would add more clarity. Additionally instead of using **SM_CXSIZEFRAME** (the name can be ambiguous too) can we change it to **SM_CXFRAME** ? Since both are mentioned to be same metrics in the documentation https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getsystemmetrics

-------------

PR: https://git.openjdk.org/jdk/pull/9954