Integrated: 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different

Harshitha Onkar honkar at openjdk.org
Fri Sep 23 16:29:27 UTC 2022


On Fri, 19 Aug 2022 23:47:49 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> On Windows, the insets obtained for a Non-Resizable AWT Frame was different when frame.pack() was called and subsequent call to frame.getInsets() or frame.getPreferredSize(). Due to this, the actual and preferred size differed when frame.pack() was called for Non-Resizable frame (on Windows).  
> 
> Earlier the insets returned when frame.getInsets() was called, was that of a Resizable frame and not the correct insets associated with Non-Resizable frame. Fix is added to native code to get the correct insets. The test - AwtFramePackTest.java has been updated to test actual and expected/preferred size for both Resizable and Non-Resizable Frames.
> 
> The test is generic though the issue and fix is on Windows platform because the condition 
> `frame.getSize() == frame.getPreferredSize()` should be true on all platforms when frame.pack() is called.
> 
> Following is the link to Windows System Metrics (used for native insets) - https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getsystemmetrics

This pull request has now been integrated.

Changeset: eca9749d
Author:    Harshitha Onkar <honkar at openjdk.org>
Committer: Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/eca9749da01d732033c07f2bbb38800a9d80f18d
Stats:     56 lines in 2 files changed: 24 ins; 12 del; 20 mod

8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different

Reviewed-by: kizune, aivanov, tr

-------------

PR: https://git.openjdk.org/jdk/pull/9954



More information about the client-libs-dev mailing list