RFR: 8293592: Remove JVM_StopThread, stillborn, and related cleanup [v2]

David Holmes dholmes at openjdk.org
Fri Sep 23 21:47:10 UTC 2022


On Fri, 23 Sep 2022 18:21:30 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> David Holmes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
>> 
>>  - Merge branch 'master' into 8293592-JVM_StopThread
>>  - Removal all special handling of ThreadDeath.
>>  - Remove all references to the stillborn field
>>  - Initial commit: remove JVM_StopThread
>>  - Merge
>>  - Updates to Java Thread Primitive Deprecation page
>>  - Repalce "it" with "victim thread"
>>  - Merge
>>  - Revert test/langtools/ProblemList.txt as jshell tests no longer rely on Thread.stop
>>  - become -> became in javadoc
>>  - ... and 6 more: https://git.openjdk.org/jdk/compare/3675f4c2...4eb07903
>
> src/jdk.jdi/share/classes/com/sun/tools/jdi/VirtualMachineManagerImpl.java line 102:
> 
>> 100:             try {
>> 101:                 connector = connectors.next();
>> 102:             } catch (Exception | Error x) {
> 
> Maybe this should just catch `Throwable`, although it is unclear to me why we would want to catch any exception here.

@plummercj  these changes are not actually part of this PR but came from the upstream PR this was dependent on.

> src/jdk.jdi/share/classes/com/sun/tools/jdi/VirtualMachineManagerImpl.java line 126:
> 
>> 124:             try {
>> 125:                 transportService = transportServices.next();
>> 126:             } catch (Exception | Error x) {
> 
> Another that could be just catch `Throwable`

@plummercj  these changes are not actually part of this PR but came from the upstream PR this was dependent on.

-------------

PR: https://git.openjdk.org/jdk/pull/10400



More information about the client-libs-dev mailing list