RFR: JDK-8292276 : Missing color names in CSS [v21]

Alexey Ivanov aivanov at openjdk.org
Mon Sep 26 17:20:21 UTC 2022


On Mon, 26 Sep 2022 17:13:40 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> ScientificWare has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Corrects Licence Header.
>>   
>>   Removes Classpath exception.
>
> test/jdk/javax/swing/text/html/CSS/MissingColorNames.java line 34:
> 
>> 32: import javax.swing.text.AttributeSet;
>> 33: import javax.swing.text.html.StyleSheet;
>> 34: import java.util.Locale;
> 
> `Locale` should be after `Color` in the imports list.

Other than that, it looks fine to me.

I am not sure about the detailed comment of when the test should fail. The thing is the comment will become if the test logic is modified and the comment is not.

-------------

PR: https://git.openjdk.org/jdk/pull/9825



More information about the client-libs-dev mailing list