RFR: JDK-8293776 : Adds CSS 4 and 8 digits hex coded Color [v9]

ScientificWare duke at openjdk.org
Tue Sep 27 03:25:57 UTC 2022


On Mon, 26 Sep 2022 11:11:07 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> ScientificWare has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Simplifications of the test.
>>   
>>   Removes individual color tests and only compares the RGB value.
>
> test/jdk/javax/swing/text/html/CSS/Hex3468DigitsColor.java line 44:
> 
>> 42:         // Then expecting 0xaaff1122 from Color.
>> 43:         Color color = styleSheet.stringToColor("#f12a");
>> 44:         result.append("  Test for #f00a");
> 
> Previously, you added a message to `result` in case of failure only, now you always do it. The updated code does not output the actual value.
> 
> The tested color is `#f12a`  instead of `#f00a`.

Done.

-------------

PR: https://git.openjdk.org/jdk/pull/10317



More information about the client-libs-dev mailing list