RFR: 6777156: GTK L&F: JFileChooser can jump beyond root directory in combobox and selection textarea. [v2]
Abhishek Kumar
duke at openjdk.org
Tue Sep 27 06:05:06 UTC 2022
On Mon, 26 Sep 2022 13:55:04 GMT, Jayathirth D V <jdv at openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Comment added and test case condotion update
>
> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChooserUI.java line 432:
>
>> 430: }
>> 431:
>> 432: public void mouseClicked(MouseEvent e) {
>
> Is this issue reproducible only through mouse click event? Can we use key navigation and return button to see same issue? Is button press using keyboard navigation treated as mouseClick event?
The same issue has been observed in case of key navigation also. we need to handle those scenario where a user is navigating through keys. I will check and update accordingly as we discussed over call.
> test/jdk/javax/swing/JFileChooser/TestFileChooserDirectorySelection.java line 57:
>
>> 55:
>> 56: robot.waitForIdle();
>> 57: robot.delay(1000);
>
> After robot.setAutoDelay() why we need such large delays in robot at many places?
I will check this and update.
-------------
PR: https://git.openjdk.org/jdk/pull/10390
More information about the client-libs-dev
mailing list