RFR: 6852577: Only for Nimbus LAF UIManager.get("PasswordField.echoChar") is null [v4]

Alexey Ivanov aivanov at openjdk.org
Wed Sep 28 09:14:28 UTC 2022


On Wed, 28 Sep 2022 03:42:38 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Default echo character obtained through `PasswordField.echoChar` UIProperty returns null for Nimbus L&F,
>> which is fixed by adding the default character * in the UIDefault table.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment fix

Marked as reviewed by aivanov (Reviewer).

test/jdk/javax/swing/plaf/nimbus/PasswordFieldTest.java line 59:

> 57:                         "PasswordField.echoChar returns null for " +
> 58:                             laf.getClassName());
> 59:                 }

A question of style: do we usually wrap lines before the operator or after? [Java Coding Style](https://www.oracle.com/java/technologies/javase/codeconventions-indentation.html#248) is for the former. This versions seems to have been updated and the code formatting is lost now; [this draft](http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html#toc-wrapping-lines) is still for the same usage.

-------------

PR: https://git.openjdk.org/jdk/pull/10035



More information about the client-libs-dev mailing list