RFR: JDK-6229853: BasicTextAreaUI:create incompletely documents the possible returned View types [v3]

Alexey Ivanov aivanov at openjdk.org
Wed Sep 28 11:52:39 UTC 2022


On Wed, 28 Sep 2022 11:41:23 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> API specification says about BasicTextAreaUI.create "Returns a WrappedPlainView or PlainView". 
>> But for [bidi](https://github.com/openjdk/jdk/blob/d14e96d9701dae951aa365029f58afb6687a646a/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextAreaUI.java#L168) text, this method returns BoxView and other views , so the documentation needs to be updated.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   javadoc fix

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextFieldUI.java line 86:

> 84: 
> 85:     /**
> 86:      * Creates a view (FieldView) based on an element.

Suggestion:

     * Creates a view based on an element.

For consistency, if we don't document the types.

-------------

PR: https://git.openjdk.org/jdk/pull/10376



More information about the client-libs-dev mailing list