RFR: JDK-8292276 : Missing color names in CSS [v6]

SWinxy duke at openjdk.org
Wed Sep 28 22:12:55 UTC 2022


On Mon, 22 Aug 2022 00:57:28 GMT, SWinxy <duke at openjdk.org> wrote:

>> ScientificWare has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removes whitespace.
>>   
>>   Remove a whitespace at the end of the file
>
> I mean I think I would *prefer* the switch over a map (it looks nicer to me). My crude tests showed that the switch is indeed slower, breaking my conception that switch statements are the peak of performance. Other than [this request](#issuecomment-1216011827), I have no further comments.

> Could we consider once more times @SWinxy 's Aug 16 comment about color instance ?

Are you talking about [keeping the old behavior](https://github.com/openjdk/jdk/pull/9825#issuecomment-1216011827)? If so, your proposed solution looks to work (also reminder that `.contains(Object)` exists).

-------------

PR: https://git.openjdk.org/jdk/pull/9825



More information about the client-libs-dev mailing list